Skip to content
This repository has been archived by the owner on May 3, 2020. It is now read-only.

Does it support splats ? #2

Open
Raynos opened this issue Aug 18, 2014 · 12 comments
Open

Does it support splats ? #2

Raynos opened this issue Aug 18, 2014 · 12 comments

Comments

@Raynos
Copy link

Raynos commented Aug 18, 2014

routes.js and express have a feature called splats ( https://github.com/aaronblohowiak/routes.js#path-formats ).

Does path-match support this or something similar to it ?

@dougwilson
Copy link

i think the latest path-to-regexp does (which this uses, unlike express 4). can someone verify :)?

@jonathanong
Copy link
Member

https://github.com/component/path-to-regexp#zero-or-more

you can do * but not *.* i think

@Raynos
Copy link
Author

Raynos commented Aug 18, 2014

One of the things I care about is being able to do an anonymous * without having to give it a name.

I guess I'll have to go add a bunch of tests to path-to-regexp.

@jonathanong
Copy link
Member

i think it was removed because of an implementation issue. also created ambiguities between * outside and inside the regexp. yeah just create issues in that repo.

@dougwilson
Copy link

yea. no one says this is the absolute best implementation :) always room to grow!

@defunctzombie
Copy link

Pillarjs? Needs a good logo! Oh Yea.. Nothing to do with this issue hahahaha

@dougwilson
Copy link

Pillarjs? Needs a good logo!

yea. @mikermcneil offered to try and help us out there :)

@mikermcneil
Copy link

@defunctzombie @dougwilson we're on it

@lyxell
Copy link

lyxell commented Nov 23, 2014

Unrelated, but since this issue is still open; is the cred to segmentio in license file for this repo correct?

@dougwilson
Copy link

@jonathanong where did that copyright come from in the LICENSE? is it correct or a mistake?

@jonathanong
Copy link
Member

made this module while working on some stuff for segment so i just put their name on it

@dougwilson
Copy link

k, then in general sounds legit to me :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants