Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid requesting creation of API key for admin since we have master key available #69

Open
pcm32 opened this issue Sep 26, 2017 · 4 comments

Comments

@pcm32
Copy link
Member

pcm32 commented Sep 26, 2017

Is there really a point in making an admin API key if we are already injecting the master API key?

Here we could just use the master API key:
https://github.com/phnmnl/container-galaxy-k8s-runtime/blob/develop/ansible/configure_galaxy.py#L154

Or any of the calls require a user owned?

This would avoid changing the admin's API key, which is currently problematic as the user creation from PhenoMeNal portal relies on a constant API key for the admin user.

Any comments @ilveroluca @kikkomep @pkrog ?

@pcm32
Copy link
Member Author

pcm32 commented Sep 26, 2017

A different solution to be able to implement what @kikkomep had to reverse some weeks ago (a16a9c7) would be to run this script inside a virtualenv with the newest bioblend version... would this work @kikkomep ?

@kikkomep
Copy link
Member

Probably a user API KEY is required to upload workflows because it allows to identify the workflow owner. The solution of running my fix inside a virtualenv with the latest bioblend version should work.

@pcm32
Copy link
Member Author

pcm32 commented Sep 26, 2017

Ok, will try it!

@ilveroluca
Copy link
Member

This can probably be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants