-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation #3
Comments
@peterpolman Great question. I was actually struggling a bit with the webpack.config. In my experiments I've created brand new Aurelia projects using the Aurelia CLI. The README suggests to extend the existing webpack.config rather than replacing the existing config, but I couldn't quite figure out how to do this, so I ended up making the necessary tweaks to the out-of-the-box webpack.config. That works, but obviously you can no longer run it in standalone mode now. Perhaps you could elaborate on how you actually extended the existing webpack.config. Did you use webpack-merge for that for example? |
Another thing I noticed after installing the new version is that I needed to change some types around which no longer matches the documentation. For example, the Perhaps it might even be better to not bother the user with the |
Yeah I extended the Aurelia interface with some private properties that we use as publics now for teardown purposes.
Your proposal makes a lot of sense though! I'll make that part of the next release or accept your PR if you're willing to submit one;) |
@peterpolman Sure, no problem. See #6 :). |
@jmezach Since you are the only one I known implementing this package you might have some additions or improvements for the readme. Feel free to submit a PR or let me know if it is sufficiently documented already.
Fyi: Also implemented support for
customProps()
to the adapter yesterday, which you might find interesting to include in your experiments.The text was updated successfully, but these errors were encountered: