Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #3

Open
peterpolman opened this issue Apr 8, 2021 · 4 comments
Open

Improve documentation #3

peterpolman opened this issue Apr 8, 2021 · 4 comments
Assignees

Comments

@peterpolman
Copy link
Owner

@jmezach Since you are the only one I known implementing this package you might have some additions or improvements for the readme. Feel free to submit a PR or let me know if it is sufficiently documented already.

Fyi: Also implemented support for customProps() to the adapter yesterday, which you might find interesting to include in your experiments.

@jmezach
Copy link
Contributor

jmezach commented Apr 8, 2021

@peterpolman Great question. I was actually struggling a bit with the webpack.config. In my experiments I've created brand new Aurelia projects using the Aurelia CLI. The README suggests to extend the existing webpack.config rather than replacing the existing config, but I couldn't quite figure out how to do this, so I ended up making the necessary tweaks to the out-of-the-box webpack.config. That works, but obviously you can no longer run it in standalone mode now. Perhaps you could elaborate on how you actually extended the existing webpack.config. Did you use webpack-merge for that for example?

@jmezach
Copy link
Contributor

jmezach commented Apr 8, 2021

Another thing I noticed after installing the new version is that I needed to change some types around which no longer matches the documentation. For example, the getInstance method now needs to return an AureliaInstance rather than an Aurelia type. Conversely the configure method now accepts a parameter aurelia of type AureliaInstance.

Perhaps it might even be better to not bother the user with the AurelaInstance type and only accept Aurelia types on the public API. Then internally we can do as AureliaInstance as needed (which I think is only in the unmount method).

@peterpolman
Copy link
Owner Author

Yeah I extended the Aurelia interface with some private properties that we use as publics now for teardown purposes.

Perhaps it might even be better to not bother the user with the AurelaInstance type and only accept Aurelia types on the public API. Then internally we can do as AureliaInstance as needed (which I think is only in the unmount method).

Your proposal makes a lot of sense though! I'll make that part of the next release or accept your PR if you're willing to submit one;)

@jmezach
Copy link
Contributor

jmezach commented Apr 15, 2021

@peterpolman Sure, no problem. See #6 :).

@peterpolman peterpolman self-assigned this May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants