Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alignment issues uncovered by -Wcast-align #4

Open
TeeEmJee opened this issue Feb 22, 2018 · 2 comments
Open

alignment issues uncovered by -Wcast-align #4

TeeEmJee opened this issue Feb 22, 2018 · 2 comments

Comments

@TeeEmJee
Copy link

Hey, I was wondering whether you are planning to change the loader in order to use proper c++ style code ( no c-like casting, more std library use etc.)?

I am dealing with many warnings on my project through the loader and some of them might become dangerous in special use cases I guess.

Unfortunately I have not enough knowledge about the code otherwise I would to that on my own.

@paroj
Copy link
Owner

paroj commented Feb 23, 2018

Hey, I was wondering whether you are planning to change the loader in order to use proper c++ style code ( no c-like casting, more std library use etc.)?

no. those would be purely cosmetic.

the only exception I see are alignment issues (enabled by -Wcast-align) on ARM architectures. (they work correctly on x86)

However those are deep in the bit-twiddling code where changes would require throughout testing.
Contributions are welcome here.

@paroj paroj changed the title use proper c++ style alignment issues uncovered by -Wcast-align Feb 23, 2018
@TeeEmJee
Copy link
Author

Okay thank's for that answer! I use the library in my C++ project and I get a few warnings about the old c-style casts and as you already mentioned about possible alignment issues. I thought it would become handy to solve these.
But I did not find a bug so it's just a matter of style I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants