Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libp2p identify protocolVersion should be set to the name of the chain #505

Open
tomaka opened this issue Jun 9, 2023 · 0 comments
Open

Comments

@tomaka
Copy link
Contributor

tomaka commented Jun 9, 2023

https://github.com/paritytech/substrate/blob/e434882d5dbf3f3f6085cb7f1d017dbc4ac11f0a/client/network/src/peer_info.rs#L98

This should be set to the id of the chain rather than just /substrate/1.0.
It is used purely for debugging, so it's very much not important, but the name of the chain is more appropriate than "substrate".

I've also opened w3f/polkadot-spec#652 so that all Polkadot nodes use the same value.

@altonen altonen transferred this issue from paritytech/substrate Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog 🗒
Development

No branches or pull requests

1 participant