Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No ability to filter contracts in the Overview page #96

Open
milda-a opened this issue Mar 13, 2023 · 1 comment
Open

No ability to filter contracts in the Overview page #96

milda-a opened this issue Mar 13, 2023 · 1 comment

Comments

@milda-a
Copy link

milda-a commented Mar 13, 2023

https://pact-foundation.slack.com/archives/C9VPNUJR2/p1678713857828619

We follow this approach currently:

Pre-merge:

  • run pact publish, use the PR branch and version variables (git sha for version)
  • once deployed to a testing env, call record-deployment to change the environment (testing)

Post-merge:

  • run pact publish, use the master branch and version (git sha changed after squash and merge)
  • once deployed to prod, call record-deployment to change the environment (prod)

This leads to multiple 'hanging' contracts to be displayed in the Overview page. We would ideally not want to see the old pre-merge branches/versions as those test environments are ephemeral and would no longer be utilised.
Ideally, we would be able to filter the Overview page to show Deployed/Released contracts only.

@mefellows
Copy link
Contributor

Thanks! As discussed on Slack, integration with the SCM provider (#45) and removing contracts related to dead branches would be one way to address this. It's probably possibly by a custom GitHub webhook that then deletes any related pacts, but I can see why that's a bit much to ask of our cusomers!

I've also wondered if we could potentially leverage information from the use of pact-broker record-deployment/release. Once an old contract has been replaced, it could potentially be marked as stale and deprioritised in the UI.

Filtering in the UI could still be a useful feature. We have a new UX/UI coming later this year (dates TBC), and the proposed screens would allow you to filter the related contracts in a similar way to your description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants