From 8bfe04bb5019bdbbc35e09ea12d068b3482a0040 Mon Sep 17 00:00:00 2001 From: JellyBrick Date: Mon, 16 Oct 2023 22:42:02 +0900 Subject: [PATCH 1/5] chore: update issue template Thanks to Alipoodle for writing this question. --- .github/ISSUE_TEMPLATE/bug_report.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index fd678bd5c9..047330c2f8 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -12,11 +12,13 @@ body: required: true - label: I have searched the [issue tracker](https://github.com/th-ch/youtube-music/issues) for a bug report that matches the one I want to file, without success. required: true + - label: I understand that **th-ch/youtube-music has NO affiliation with Google or YouTube** + required: true - type: input attributes: label: YouTube Music (Application) Version description: | - What version of YouTube Music Application are you using? + What version of the YouTube Music Application are you using? Note: Please check if this issue is reproducible with the latest stable release. placeholder: 2.0.0 @@ -36,7 +38,7 @@ body: - type: input attributes: label: Operating System Version - description: What operating system version are you using? On Windows, click Start button > Settings > System > About. On macOS, click the Apple Menu > About This Mac. On Linux, use lsb_release or uname -a. + description: What operating system version are you using? On Windows, click the Start button > Settings > System > About. On macOS, click the Apple Menu > About This Mac. On Linux, use lsb_release or uname -a. placeholder: "e.g. Windows 10 version 1909, macOS Catalina 10.15.7, or Ubuntu 20.04" validations: required: true From 9a4e98063bfbbfaca85cb78eab4747701793a8af Mon Sep 17 00:00:00 2001 From: JellyBrick Date: Mon, 16 Oct 2023 22:54:11 +0900 Subject: [PATCH 2/5] chore(actions): disable pnpm cache for macOS --- .github/workflows/build.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 9456e9db58..17a563af92 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -27,11 +27,18 @@ jobs: run_install: false - name: Setup NodeJS + if: startsWith(matrix.os, 'macOS') != true && github.repository != 'th-ch/youtube-music' uses: actions/setup-node@v3 with: node-version: ${{ env.NODE_VERSION }} cache: 'pnpm' + - name: Setup NodeJS for macOS + if: startsWith(matrix.os, 'macOS') && github.repository != 'th-ch/youtube-music' + uses: actions/setup-node@v3 + with: + node-version: ${{ env.NODE_VERSION }} + - name: Install dependencies run: pnpm install --frozen-lockfile @@ -97,11 +104,18 @@ jobs: run_install: false - name: Setup NodeJS + if: startsWith(matrix.os, 'macOS') != true && github.repository != 'th-ch/youtube-music' uses: actions/setup-node@v3 with: node-version: ${{ env.NODE_VERSION }} cache: 'pnpm' + - name: Setup NodeJS for macOS + if: startsWith(matrix.os, 'macOS') && github.repository != 'th-ch/youtube-music' + uses: actions/setup-node@v3 + with: + node-version: ${{ env.NODE_VERSION }} + - name: Install dependencies run: pnpm install --frozen-lockfile From 4e4af5e8309737128db2add7be998fab70590e89 Mon Sep 17 00:00:00 2001 From: JellyBrick Date: Mon, 16 Oct 2023 22:55:04 +0900 Subject: [PATCH 3/5] fix(actions): fix if statement --- .github/workflows/build.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 17a563af92..76c67631c4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -27,14 +27,14 @@ jobs: run_install: false - name: Setup NodeJS - if: startsWith(matrix.os, 'macOS') != true && github.repository != 'th-ch/youtube-music' + if: startsWith(matrix.os, 'macOS') != true uses: actions/setup-node@v3 with: node-version: ${{ env.NODE_VERSION }} cache: 'pnpm' - name: Setup NodeJS for macOS - if: startsWith(matrix.os, 'macOS') && github.repository != 'th-ch/youtube-music' + if: startsWith(matrix.os, 'macOS') uses: actions/setup-node@v3 with: node-version: ${{ env.NODE_VERSION }} @@ -104,14 +104,14 @@ jobs: run_install: false - name: Setup NodeJS - if: startsWith(matrix.os, 'macOS') != true && github.repository != 'th-ch/youtube-music' + if: startsWith(matrix.os, 'macOS') != true uses: actions/setup-node@v3 with: node-version: ${{ env.NODE_VERSION }} cache: 'pnpm' - name: Setup NodeJS for macOS - if: startsWith(matrix.os, 'macOS') && github.repository != 'th-ch/youtube-music' + if: startsWith(matrix.os, 'macOS') uses: actions/setup-node@v3 with: node-version: ${{ env.NODE_VERSION }} From c460cc22963ffaf37910fd289af5b1a3f64ad0e6 Mon Sep 17 00:00:00 2001 From: Iliq Iliev Date: Tue, 17 Oct 2023 14:04:23 +0300 Subject: [PATCH 4/5] Updated readme plugins list (#1326) --- readme.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/readme.md b/readme.md index 55b16441a0..0d8a2a717a 100644 --- a/readme.md +++ b/readme.md @@ -79,6 +79,10 @@ winget install th-ch.YouTubeMusic - **Ad Blocker**: Block all ads and tracking out of the box +- **Album Color Theme**: Applies a dynamic theme and visual effects based on the album color palette + +- **Ambient Mode**: Applies a lighting effect by casting gentle colors from the video, into your screen’s background. + - **Audio Compressor**: Apply compression to audio (lowers the volume of the loudest parts of the signal and raises the volume of the softest parts) @@ -111,6 +115,8 @@ winget install th-ch.YouTubeMusic - [**Last.fm**](https://www.last.fm/): Scrobbles support +- **Lumia Stream**: Adds [Lumia Stream](https://lumiastream.com/) support + - **Lyrics Genius**: Adds lyrics support for most songs - **Navigation**: Next/Back navigation arrows directly integrated in the interface, like in your favorite browser From fa3d742838143c5537571ca57bd1696943af70ad Mon Sep 17 00:00:00 2001 From: JellyBrick Date: Wed, 18 Oct 2023 02:21:25 +0900 Subject: [PATCH 5/5] chore(deps): update dependency @typescript-eslint/eslint-plugin to v6.8.0 --- package.json | 2 +- pnpm-lock.yaml | 76 +++++++++++++++++++++++++++++++++++++++----------- 2 files changed, 60 insertions(+), 18 deletions(-) diff --git a/package.json b/package.json index 93a04e7d92..ae564b12a5 100644 --- a/package.json +++ b/package.json @@ -176,7 +176,7 @@ "@types/electron-localshortcut": "3.1.1", "@types/howler": "2.2.9", "@types/html-to-text": "9.0.2", - "@typescript-eslint/eslint-plugin": "6.7.5", + "@typescript-eslint/eslint-plugin": "6.8.0", "auto-changelog": "2.4.0", "builtin-modules": "^3.3.0", "cross-env": "7.0.3", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 4a6ce31310..0614073213 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -145,8 +145,8 @@ devDependencies: specifier: 9.0.2 version: 9.0.2 '@typescript-eslint/eslint-plugin': - specifier: 6.7.5 - version: 6.7.5(@typescript-eslint/parser@6.7.5)(eslint@8.51.0)(typescript@5.2.2) + specifier: 6.8.0 + version: 6.8.0(@typescript-eslint/parser@6.7.5)(eslint@8.51.0)(typescript@5.2.2) auto-changelog: specifier: 2.4.0 version: 2.4.0 @@ -1042,8 +1042,8 @@ packages: '@types/node': 18.18.5 optional: true - /@typescript-eslint/eslint-plugin@6.7.5(@typescript-eslint/parser@6.7.5)(eslint@8.51.0)(typescript@5.2.2): - resolution: {integrity: sha512-JhtAwTRhOUcP96D0Y6KYnwig/MRQbOoLGXTON2+LlyB/N35SP9j1boai2zzwXb7ypKELXMx3DVk9UTaEq1vHEw==} + /@typescript-eslint/eslint-plugin@6.8.0(@typescript-eslint/parser@6.7.5)(eslint@8.51.0)(typescript@5.2.2): + resolution: {integrity: sha512-GosF4238Tkes2SHPQ1i8f6rMtG6zlKwMEB0abqSJ3Npvos+doIlc/ATG+vX1G9coDF3Ex78zM3heXHLyWEwLUw==} engines: {node: ^16.0.0 || >=18.0.0} peerDependencies: '@typescript-eslint/parser': ^6.0.0 || ^6.0.0-alpha @@ -1055,10 +1055,10 @@ packages: dependencies: '@eslint-community/regexpp': 4.9.1 '@typescript-eslint/parser': 6.7.5(eslint@8.51.0)(typescript@5.2.2) - '@typescript-eslint/scope-manager': 6.7.5 - '@typescript-eslint/type-utils': 6.7.5(eslint@8.51.0)(typescript@5.2.2) - '@typescript-eslint/utils': 6.7.5(eslint@8.51.0)(typescript@5.2.2) - '@typescript-eslint/visitor-keys': 6.7.5 + '@typescript-eslint/scope-manager': 6.8.0 + '@typescript-eslint/type-utils': 6.8.0(eslint@8.51.0)(typescript@5.2.2) + '@typescript-eslint/utils': 6.8.0(eslint@8.51.0)(typescript@5.2.2) + '@typescript-eslint/visitor-keys': 6.8.0 debug: 4.3.4 eslint: 8.51.0 graphemer: 1.4.0 @@ -1100,8 +1100,16 @@ packages: '@typescript-eslint/visitor-keys': 6.7.5 dev: true - /@typescript-eslint/type-utils@6.7.5(eslint@8.51.0)(typescript@5.2.2): - resolution: {integrity: sha512-Gs0qos5wqxnQrvpYv+pf3XfcRXW6jiAn9zE/K+DlmYf6FcpxeNYN0AIETaPR7rHO4K2UY+D0CIbDP9Ut0U4m1g==} + /@typescript-eslint/scope-manager@6.8.0: + resolution: {integrity: sha512-xe0HNBVwCph7rak+ZHcFD6A+q50SMsFwcmfdjs9Kz4qDh5hWhaPhFjRs/SODEhroBI5Ruyvyz9LfwUJ624O40g==} + engines: {node: ^16.0.0 || >=18.0.0} + dependencies: + '@typescript-eslint/types': 6.8.0 + '@typescript-eslint/visitor-keys': 6.8.0 + dev: true + + /@typescript-eslint/type-utils@6.8.0(eslint@8.51.0)(typescript@5.2.2): + resolution: {integrity: sha512-RYOJdlkTJIXW7GSldUIHqc/Hkto8E+fZN96dMIFhuTJcQwdRoGN2rEWA8U6oXbLo0qufH7NPElUb+MceHtz54g==} engines: {node: ^16.0.0 || >=18.0.0} peerDependencies: eslint: ^7.0.0 || ^8.0.0 @@ -1110,8 +1118,8 @@ packages: typescript: optional: true dependencies: - '@typescript-eslint/typescript-estree': 6.7.5(typescript@5.2.2) - '@typescript-eslint/utils': 6.7.5(eslint@8.51.0)(typescript@5.2.2) + '@typescript-eslint/typescript-estree': 6.8.0(typescript@5.2.2) + '@typescript-eslint/utils': 6.8.0(eslint@8.51.0)(typescript@5.2.2) debug: 4.3.4 eslint: 8.51.0 ts-api-utils: 1.0.3(typescript@5.2.2) @@ -1125,6 +1133,11 @@ packages: engines: {node: ^16.0.0 || >=18.0.0} dev: true + /@typescript-eslint/types@6.8.0: + resolution: {integrity: sha512-p5qOxSum7W3k+llc7owEStXlGmSl8FcGvhYt8Vjy7FqEnmkCVlM3P57XQEGj58oqaBWDQXbJDZxwUWMS/EAPNQ==} + engines: {node: ^16.0.0 || >=18.0.0} + dev: true + /@typescript-eslint/typescript-estree@6.7.5(typescript@5.2.2): resolution: {integrity: sha512-NhJiJ4KdtwBIxrKl0BqG1Ur+uw7FiOnOThcYx9DpOGJ/Abc9z2xNzLeirCG02Ig3vkvrc2qFLmYSSsaITbKjlg==} engines: {node: ^16.0.0 || >=18.0.0} @@ -1146,8 +1159,29 @@ packages: - supports-color dev: true - /@typescript-eslint/utils@6.7.5(eslint@8.51.0)(typescript@5.2.2): - resolution: {integrity: sha512-pfRRrH20thJbzPPlPc4j0UNGvH1PjPlhlCMq4Yx7EGjV7lvEeGX0U6MJYe8+SyFutWgSHsdbJ3BXzZccYggezA==} + /@typescript-eslint/typescript-estree@6.8.0(typescript@5.2.2): + resolution: {integrity: sha512-ISgV0lQ8XgW+mvv5My/+iTUdRmGspducmQcDw5JxznasXNnZn3SKNrTRuMsEXv+V/O+Lw9AGcQCfVaOPCAk/Zg==} + engines: {node: ^16.0.0 || >=18.0.0} + peerDependencies: + typescript: '*' + peerDependenciesMeta: + typescript: + optional: true + dependencies: + '@typescript-eslint/types': 6.8.0 + '@typescript-eslint/visitor-keys': 6.8.0 + debug: 4.3.4 + globby: 11.1.0 + is-glob: 4.0.3 + semver: 7.5.4 + ts-api-utils: 1.0.3(typescript@5.2.2) + typescript: 5.2.2 + transitivePeerDependencies: + - supports-color + dev: true + + /@typescript-eslint/utils@6.8.0(eslint@8.51.0)(typescript@5.2.2): + resolution: {integrity: sha512-dKs1itdE2qFG4jr0dlYLQVppqTE+Itt7GmIf/vX6CSvsW+3ov8PbWauVKyyfNngokhIO9sKZeRGCUo1+N7U98Q==} engines: {node: ^16.0.0 || >=18.0.0} peerDependencies: eslint: ^7.0.0 || ^8.0.0 @@ -1155,9 +1189,9 @@ packages: '@eslint-community/eslint-utils': 4.4.0(eslint@8.51.0) '@types/json-schema': 7.0.13 '@types/semver': 7.5.3 - '@typescript-eslint/scope-manager': 6.7.5 - '@typescript-eslint/types': 6.7.5 - '@typescript-eslint/typescript-estree': 6.7.5(typescript@5.2.2) + '@typescript-eslint/scope-manager': 6.8.0 + '@typescript-eslint/types': 6.8.0 + '@typescript-eslint/typescript-estree': 6.8.0(typescript@5.2.2) eslint: 8.51.0 semver: 7.5.4 transitivePeerDependencies: @@ -1173,6 +1207,14 @@ packages: eslint-visitor-keys: 3.4.3 dev: true + /@typescript-eslint/visitor-keys@6.8.0: + resolution: {integrity: sha512-oqAnbA7c+pgOhW2OhGvxm0t1BULX5peQI/rLsNDpGM78EebV3C9IGbX5HNZabuZ6UQrYveCLjKo8Iy/lLlBkkg==} + engines: {node: ^16.0.0 || >=18.0.0} + dependencies: + '@typescript-eslint/types': 6.8.0 + eslint-visitor-keys: 3.4.3 + dev: true + /@xhayper/discord-rpc@1.0.24: resolution: {integrity: sha512-gzC8OaOSz7cGALSHyyq6nANQvBfyfntbSq+Qh+cNanoKX8ybOj+jWKmDP6PbLVDWoBftTU3JYsWXrLml2df2Hw==} engines: {node: '>=14.18.0'}