Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block volume provisioning customization in instance-pool mode #969

Open
ddevadat opened this issue Dec 10, 2024 · 0 comments
Open

Block volume provisioning customization in instance-pool mode #969

ddevadat opened this issue Dec 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ddevadat
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Block volume provisioning customization in instance-pool mode

New or Affected Resource(s)

When we create worker node in instance-pool mode, the module creates a 50Gb Block volume and attaches the compute instance.

Right now there is no option to opt out of this. I have seen use case where customer want to create worker pool in instance-pool mode, but dont really need the block volume. Its an extra unwanted cost to them and they cant opt out.

Also if a customer do want to opt in, it would be better to customize the block volume size. Just a thought.

Potential Terraform Configuration

https://github.com/oracle-terraform-modules/terraform-oci-oke/blob/2c7037a41cc4bea47e648e2f622d22bae2db9f40/modules/workers/instanceconfig.tf#L119C1-L132C6

# Copy-paste any Terraform configurations for how the requested feature may be used. 
    block_volumes {
      attach_details {
        type                                = each.value.block_volume_type
        is_pv_encryption_in_transit_enabled = each.value.pv_transit_encryption
      }

      create_details {
        // Limit to first candidate placement AD for cluster-network; undefined for all otherwise
        availability_domain = each.value.mode == "cluster-network" ? element(each.value.availability_domains, 1) : null
        compartment_id      = each.value.compartment_id
        display_name        = each.key
        kms_key_id          = each.value.volume_kms_key_id
      }
    }

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant