You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At entry_point.sh all side files are processed by runner
selenium-side-runner (...) /sides/*.side
But plugin script check_selenium_docker.py wait for and process only the first json output:
side = glob.glob(path + '/sides/*.side')
side_file = open(side[0],'r')
(...)
result = path + '/out/' + side_json['name'] + '.json'
(...)
while not os.path.isfile(result) and waitedfor <= timeout:
It also calculates exec_time and prints failureMessage based only on the first failed test. If side file contains more than one Test Suite then could be more failed tests:
And finally runner's output failure messages are quite long and multi-line which is a bit in a contrary with a Nagions Guidelines that encourages brevity.
I fixed it all in my fork. I will do a PR if you would like to merge it.
ps. Good job with this plugin :).
The text was updated successfully, but these errors were encountered:
At
entry_point.sh
all side files are processed by runnerBut plugin script
check_selenium_docker.py
wait for and process only the first json output:It also calculates
exec_time
and printsfailureMessage
based only on the first failed test. If side file contains more than one Test Suite then could be more failed tests:And finally runner's output failure messages are quite long and multi-line which is a bit in a contrary with a Nagions Guidelines that encourages brevity.
I fixed it all in my fork. I will do a PR if you would like to merge it.
ps. Good job with this plugin :).
The text was updated successfully, but these errors were encountered: