Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCS fcov false support #1179

Open
jordancarlin opened this issue Dec 7, 2024 · 4 comments
Open

VCS fcov false support #1179

jordancarlin opened this issue Dec 7, 2024 · 4 comments
Assignees

Comments

@jordancarlin
Copy link
Member

wsim supports passing --fcov when using VCS and the run_vcs script accepts the --fcov flag, but it does not do anything with the flag so functional coverage is not actually generated. The run_vcs script either needs to be updated to properly support fcov or this flag should be disabled. @davidharrishmc not sure which path you want to take with this one.

@davidharrishmc
Copy link
Contributor

davidharrishmc commented Dec 8, 2024 via email

@jordancarlin
Copy link
Member Author

Code coverage is already set up. Just needed a quick fix that I pushed in #1177.

I'm making some changes to how fcov is handled by wsim in my next PR. I think with those changes it will be trivial to support it in VCS, but if that turns out not to be the case then I'll go ahead and have it print out an error instead of its current behavior of silently failing.

@davidharrishmc
Copy link
Contributor

davidharrishmc commented Dec 8, 2024 via email

@jordancarlin
Copy link
Member Author

jordancarlin commented Dec 8, 2024 via email

@jordancarlin jordancarlin self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants