Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OrderUpdate to update price, quantity #24

Open
kilrau opened this issue May 25, 2020 · 1 comment
Open

OrderUpdate to update price, quantity #24

kilrau opened this issue May 25, 2020 · 1 comment
Assignees
@LePremierHomme
Labels
enhancement New feature or request hardening All things to reduce edge cases and make the protocol less error prone help wanted Extra attention is needed

Comments

@kilrau
Copy link
Contributor

kilrau commented May 25, 2020

Problem:
Currently we are only supporting order invalidation (0x07) and re-issuing a new order (0x06) which is not ideal and somewhat error prone since implementations need to take care of processing things in the right order, also there is short time frame where there the order is not available.

Proposal:
This issue is about a new message type OrderUpdate (e.g. as 0x10 or 0x061/0x6b) which instructs a peer to update price and/or quantity of the order without invalidation and order downtime.
@kilrau kilrau added enhancement New feature or request help wanted Extra attention is needed hardening All things to reduce edge cases and make the protocol less error prone labels May 25, 2020
@kilrau
Copy link
Contributor Author

kilrau commented Jan 4, 2021

Needs to be added to specs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LePremierHomme LePremierHomme

Labels
enhancement New feature or request hardening All things to reduce edge cases and make the protocol less error prone help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kilrau @LePremierHomme