From a83b59e079eeb680df56a667c1b9fec91818b5df Mon Sep 17 00:00:00 2001 From: Gerard Ryan Date: Mon, 21 Oct 2024 19:12:13 +0100 Subject: [PATCH] Tidy up run-nowebhook recipe & make clean PHONY (#1310) * chore: Tidy run-nowebhook recipe The suggestion to tidy up the run-nowebhook recipe comes from this conversation: https://github.com/opendatahub-io/opendatahub-operator/pull/1304/files#r1806731373 * chore: Make `clean` a PHONY target I believe `clean` should be a PHONY target, since it doesn't create a file called `clean` (cherry picked from commit b91bd2981c5fe5b9182fef006dffbab4d731e772) --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index c7778194770..44f21aac22c 100644 --- a/Makefile +++ b/Makefile @@ -188,8 +188,7 @@ run: manifests generate fmt vet ## Run a controller from your host. .PHONY: run-nowebhook run-nowebhook: GO_RUN_ARGS += -tags nowebhook -run-nowebhook: manifests generate fmt vet ## Run a controller from your host without webhook enabled - $(GO_RUN_MAIN) +run-nowebhook: run ## Run a controller from your host without webhook enabled .PHONY: image-build image-build: # unit-test ## Build image with the manager. @@ -380,6 +379,7 @@ CLEANFILES += cover.out e2e-test: ## Run e2e tests for the controller go test ./tests/e2e/ -run ^TestOdhOperator -v --operator-namespace=${OPERATOR_NAMESPACE} ${E2E_TEST_FLAGS} +.PHONY: clean clean: $(GOLANGCI_LINT) $(GOLANGCI_LINT) cache clean chmod u+w -R $(LOCALBIN) # envtest makes its dir RO