From 72864b58cc2df8c9b366df07e4a8e180b3945a36 Mon Sep 17 00:00:00 2001 From: Tameem Bin Haider Date: Wed, 1 Jan 2025 18:37:15 +0600 Subject: [PATCH 1/3] fix: show ready for review tab for register scope --- packages/client/src/hooks/useNavigation.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/client/src/hooks/useNavigation.ts b/packages/client/src/hooks/useNavigation.ts index b8d2f445e1..7026c0fa70 100644 --- a/packages/client/src/hooks/useNavigation.ts +++ b/packages/client/src/hooks/useNavigation.ts @@ -66,7 +66,8 @@ const routeAccess: NavigationConfig[] = [ name: WORKQUEUE_TABS.readyForReview, scopes: [ SCOPES.RECORD_SUBMIT_FOR_APPROVAL, - SCOPES.RECORD_SUBMIT_FOR_UPDATES + SCOPES.RECORD_SUBMIT_FOR_UPDATES, + SCOPES.RECORD_REGISTER ] }, { From d287bcf793de997e1c37c0acb02df39150914bd5 Mon Sep 17 00:00:00 2001 From: Tameem Bin Haider Date: Wed, 1 Jan 2025 19:02:02 +0600 Subject: [PATCH 2/3] fix: hide send incomplete btn without req scope --- .../components/form/ReviewActionComponent.tsx | 32 +++++++++++-------- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/packages/client/src/components/form/ReviewActionComponent.tsx b/packages/client/src/components/form/ReviewActionComponent.tsx index 411b137ca1..43a26f094d 100644 --- a/packages/client/src/components/form/ReviewActionComponent.tsx +++ b/packages/client/src/components/form/ReviewActionComponent.tsx @@ -388,29 +388,33 @@ const ReviewActionComponent = ({ {intl.formatMessage(buttonMessages.sendForApproval)} + ) : completeDeclaration ? ( + <> + + + + ) : ( <> - + From d8d0627909a4bb75a00adcaa48053690a78535e7 Mon Sep 17 00:00:00 2001 From: Tameem Bin Haider Date: Wed, 1 Jan 2025 19:23:31 +0600 Subject: [PATCH 3/3] test: add required scope for ready for review tab --- packages/client/src/components/interface/Navigation.test.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/client/src/components/interface/Navigation.test.tsx b/packages/client/src/components/interface/Navigation.test.tsx index 25b22b5d09..4722f14142 100644 --- a/packages/client/src/components/interface/Navigation.test.tsx +++ b/packages/client/src/components/interface/Navigation.test.tsx @@ -348,7 +348,8 @@ describe('Given a user with scopes views Navigation', () => { const requiredScopes = [ SCOPES.RECORD_SUBMIT_FOR_APPROVAL, - SCOPES.RECORD_SUBMIT_FOR_UPDATES + SCOPES.RECORD_SUBMIT_FOR_UPDATES, + SCOPES.RECORD_REGISTER ] as Scope[] const allOtherScopes = allScopes.filter(