From 5b55fb7114f1a9622b55f22d45d26df44efaef9b Mon Sep 17 00:00:00 2001 From: Alexey Alexandrov Date: Fri, 17 May 2024 16:44:32 -0700 Subject: [PATCH] Consistently use int64 type for string refs in pprofextended. Fixing two fields that used a different type, I don't think there is a good reason to be inconsistent. --- .../proto/profiles/v1experimental/pprofextended.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/opentelemetry/proto/profiles/v1experimental/pprofextended.proto b/opentelemetry/proto/profiles/v1experimental/pprofextended.proto index 5ebe1fd93..61ae3c416 100644 --- a/opentelemetry/proto/profiles/v1experimental/pprofextended.proto +++ b/opentelemetry/proto/profiles/v1experimental/pprofextended.proto @@ -235,7 +235,7 @@ message Sample { // Supersedes location_index. uint64 locations_length = 8; // A 128bit id that uniquely identifies this stacktrace, globally. Index into string table. [optional] - uint32 stacktrace_id_index = 9; + int64 stacktrace_id_index = 9; // The type and unit of each value is defined by the corresponding // entry in Profile.sample_type. All samples must have the same // number of values, the same as the length of Profile.sample_type. @@ -355,7 +355,7 @@ message Location { bool is_folded = 5; // Type of frame (e.g. kernel, native, python, hotspot, php). Index into string table. - uint32 type_index = 6; + int64 type_index = 6; // References to attributes in Profile.attribute_table. [optional] repeated uint64 attributes = 7;