From 833a4ebd5318b3dce6a63b323ff7a6f44b43472c Mon Sep 17 00:00:00 2001 From: Florian Lehner Date: Wed, 4 Sep 2024 15:32:43 +0200 Subject: [PATCH] profiles: drop Sample.stacktrace_id_index (#575) The value for Sample.stacktrace_id_index is hardly defined except for its length. It is also not defined how this value should be generated, interpreted and could be used. Some kind of stacktrace_id can be most efficient in stateful protocols, where transmitting duplicate information should be avoided. As the OTel Profiling protocol is a stateless protocol, this element can be droped. --- opentelemetry/proto/profiles/v1experimental/pprofextended.proto | 2 -- 1 file changed, 2 deletions(-) diff --git a/opentelemetry/proto/profiles/v1experimental/pprofextended.proto b/opentelemetry/proto/profiles/v1experimental/pprofextended.proto index 42c0a9df6..46136b166 100644 --- a/opentelemetry/proto/profiles/v1experimental/pprofextended.proto +++ b/opentelemetry/proto/profiles/v1experimental/pprofextended.proto @@ -234,8 +234,6 @@ message Sample { // locations_length along with locations_start_index refers to a slice of locations in Profile.location. // Supersedes location_index. uint64 locations_length = 8; - // A 128bit id that uniquely identifies this stacktrace, globally. Index into string table. [optional] - uint32 stacktrace_id_index = 9; // The type and unit of each value is defined by the corresponding // entry in Profile.sample_type. All samples must have the same // number of values, the same as the length of Profile.sample_type.