Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: Repository maintenance on opentelemetry-collector-releases #2403

Closed
mowies opened this issue Oct 17, 2024 · 10 comments
Closed

REQUEST: Repository maintenance on opentelemetry-collector-releases #2403

mowies opened this issue Oct 17, 2024 · 10 comments
Labels
area/repo-maintenance Maintenance of repos in the open-telemetry org

Comments

@mowies
Copy link
Member

mowies commented Oct 17, 2024

Affected Repository

https://github.com/open-telemetry/opentelemetry-collector-releases

Requested changes

  1. Enable the renovate app for the repo
  2. ensure branch protection rules for renovatebot/ branches are setup to allow them to be updated main/docs/how-to-configure-new-repository.md#branch-protection-rule-renovate

Purpose

The releases repo would like to start using renovate for dependency management.

Expected Duration

permanently

Repository Maintainers

  • @open-telemetry/collector-maintainers
  • @open-telemetry/collector-contrib-maintainers
@mx-psi
Copy link
Member

mx-psi commented Oct 17, 2024

I support this

@trask
Copy link
Member

trask commented Oct 25, 2024

sorry for the delay, I'll do this tomorrow if no one picks it up before then

@trask
Copy link
Member

trask commented Oct 26, 2024

I've installed the app, and set up the branch protections

https://developer.mend.io/github/open-telemetry reports that opentelemetry-collector-releases status is "onboarding"

I think it's supposed to send a PR to onboard the repo, but it looks like there is an old PR in the repo from a prior onboarding: open-telemetry/opentelemetry-collector-releases#426

and that PR's branch is also still around renovate/configure

based on https://github.com/renovatebot/renovate/blob/main/docs/usage/getting-started/installing-onboarding.md#nuke-config-and-re-onboard, I'm going to rename the old renovate onboarding PR and delete that PR's branch...

@trask
Copy link
Member

trask commented Oct 26, 2024

I've renamed the old renovate onboarding PR: open-telemetry/opentelemetry-collector-releases#426

and deleted that PR's branch: renovate/configure

based on https://github.com/renovatebot/renovate/blob/main/docs/usage/getting-started/installing-onboarding.md#nuke-config-and-re-onboard, it sounded like it could take a few hours for Renovate to notice and send a new onboarding PR

so I uninstalled and re-installed the app to the opentelemetry-collector-releases repository to try to trigger re-onbarding sooner, but that didn't seem to speed up the process

so I manually triggered a renovate scan at https://developer.mend.io/github/open-telemetry/opentelemetry-collector-releases, and that did the trick and (re-)created the onboarding PR: open-telemetry/opentelemetry-collector-releases#709

@mowies
Copy link
Member Author

mowies commented Oct 28, 2024

thanks for going through that trouble 😅

@trask
Copy link
Member

trask commented Oct 29, 2024

@mowies let us know if everything is good, and if it's ok to close this issue, thanks!

@mowies
Copy link
Member Author

mowies commented Oct 30, 2024

I would have closed this when the configuration PR is merged to make sure that it all works correctly. But we can close now as well and I'll reopen if there's any issues.

@mowies
Copy link
Member Author

mowies commented Oct 30, 2024

As a follow-up to this, we'll need to also disable dependabot in the releases repo after we made sure that everything works with renovate. Should I create a separate issue for that or do we re-use this one here @trask ?

@trask
Copy link
Member

trask commented Oct 30, 2024

sure, we can keep this issue open until you're able to confirm everything is working correctly

IIRC, you disable dependabot by removing the .github/dependabot.yml file from the repo. Try that when you're ready, and check if that is reflected here: https://github.com/open-telemetry/opentelemetry-collector-releases/network/updates

@mowies
Copy link
Member Author

mowies commented Nov 13, 2024

Ok I can confirm that everything works as expected.
Will remove the dependabot file next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/repo-maintenance Maintenance of repos in the open-telemetry org
Projects
Status: Done
Development

No branches or pull requests

3 participants