Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Send notifications when PRs are labeled #5

Open
2 tasks done
bdougie opened this issue Mar 1, 2022 · 1 comment
Open
2 tasks done

Feature: Send notifications when PRs are labeled #5

bdougie opened this issue Mar 1, 2022 · 1 comment
Labels
💡 feature good first issue Good for newcomers

Comments

@bdougie
Copy link
Member

bdougie commented Mar 1, 2022 •
edited
Loading

Type of feature

🍕 Feature

Current behavior

Currently this app sends notifications when the issue labeled "good first issue"

Suggested solution

It would be great to add "ready for review" for PRs looking for crowd-sourced reviews.

The "pull_request.labeled" can be used and a filter for "ready-for-review" can be be added to a new function that sends a new message. Similar to "issues.labeled"

Additional context

An update to this will need to be deployed

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@0-vortex
Copy link
Contributor

0-vortex commented Mar 1, 2022

This looks like 2 issues, we could use a "command" type level code split and then direct some command -> some action, might be fun to do in pairs, however, can pick this up on my own and do both :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💡 feature good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0-vortex @bdougie