Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple merge to master in same day might cause published version crashing in elixir-omg #36

Open
boolafish opened this issue Feb 18, 2020 · 0 comments

Comments

@boolafish
Copy link
Contributor

Description

Currently, elixir-omg tracked the contract deployer via: publish date + contract git sha.
In most of the case this would work well. However, some recent PR shows that this can break elixir-omg consistency since elixir-omg is not tracking the version of what is published here.

The following 2 PRs: #35, #34 are merged in same day, causing conflict on (publish data, contract git sha) not unique, resulting elixir-omg CI and local development start to fail (docker-compose up would fail). (Since it is upgrading Geth version, and sadly it does not work well without elixir-omg change: omgnetwork/elixir-omg#1324)

Proposal

eh...add git hash of this to our published deployer file path? so publish_date, contract_sha, sha_of_this_repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant