You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, elixir-omg tracked the contract deployer via: publish date + contract git sha.
In most of the case this would work well. However, some recent PR shows that this can break elixir-omg consistency since elixir-omg is not tracking the version of what is published here.
The following 2 PRs: #35, #34 are merged in same day, causing conflict on (publish data, contract git sha) not unique, resulting elixir-omg CI and local development start to fail (docker-compose up would fail). (Since it is upgrading Geth version, and sadly it does not work well without elixir-omg change: omgnetwork/elixir-omg#1324)
Proposal
eh...add git hash of this to our published deployer file path? so publish_date, contract_sha, sha_of_this_repo?
The text was updated successfully, but these errors were encountered:
Description
Currently, elixir-omg tracked the contract deployer via:
publish date + contract git sha
.In most of the case this would work well. However, some recent PR shows that this can break elixir-omg consistency since elixir-omg is not tracking the version of what is published here.
The following 2 PRs: #35, #34 are merged in same day, causing conflict on
(publish data, contract git sha)
not unique, resulting elixir-omg CI and local development start to fail (docker-compose up
would fail). (Since it is upgrading Geth version, and sadly it does not work well without elixir-omg change: omgnetwork/elixir-omg#1324)Proposal
eh...add git hash of this to our published deployer file path? so
publish_date, contract_sha, sha_of_this_repo
?The text was updated successfully, but these errors were encountered: