You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was browsing the sync docs and found this issue in Odin/core/sync/futex_windows.odin. Typos in the comments make the meaning somewhat unclear. If I should submit a PR to fix the comments, let me know.
Expected Behavior
Correct English.
Current Behavior
Line 23:
/*
NOTE(bill, 2022-08-17)
WaitOnAddress is implemented on top of RtlWaitOnAddress
BUT requires taking the return value of it and if it is non-zero
converting that status to a DOS error and then SetLastError
If this is not done, then things don't work as expected when
and error occurs
GODDAMN MICROSOFT!
*/
...
Line 49:
// NOTE(bill): for some bizarre reason, this has be a negative number
Expected meaning
Line 23:
/*
NOTE(bill, 2022-08-17)
WaitOnAddress is implemented on top of RtlWaitOnAddress
BUT requires taking the return value of it and if it is non-zero
converting that status to a DOS error and then SetLastError
If this is not done, then things don't work as expected when
an error occurs
GODDAMN MICROSOFT!
*/
...
Line 49:
// NOTE(bill): for some bizarre reason, this has to be a negative number
The text was updated successfully, but these errors were encountered:
Context
I was browsing the sync docs and found this issue in Odin/core/sync/futex_windows.odin. Typos in the comments make the meaning somewhat unclear. If I should submit a PR to fix the comments, let me know.
Expected Behavior
Correct English.
Current Behavior
Line 23:
/*
NOTE(bill, 2022-08-17)
WaitOnAddress is implemented on top of RtlWaitOnAddress
BUT requires taking the return value of it and if it is non-zero
converting that status to a DOS error and then SetLastError
If this is not done, then things don't work as expected when
and error occurs
*/
...
Line 49:
// NOTE(bill): for some bizarre reason, this has be a negative number
Expected meaning
Line 23:
/*
NOTE(bill, 2022-08-17)
WaitOnAddress is implemented on top of RtlWaitOnAddress
BUT requires taking the return value of it and if it is non-zero
converting that status to a DOS error and then SetLastError
If this is not done, then things don't work as expected when
an error occurs
*/
...
Line 49:
// NOTE(bill): for some bizarre reason, this has to be a negative number
The text was updated successfully, but these errors were encountered: