Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script can fail if interrupted #6

Open
ocdtrekkie opened this issue Nov 13, 2019 · 1 comment
Open

Update script can fail if interrupted #6

ocdtrekkie opened this issue Nov 13, 2019 · 1 comment

Comments

@ocdtrekkie
Copy link
Owner

If during the preferred update flow, ExtractToDirectory creates the temp directory, but the update is interrupted prior to the batch file deleting the temp directory, future attempts to update will cause a crash. ExtractToDirectory has a handy "overwriteFiles" capability starting in .NET Core 2 which would elegantly dodge this possibility, but it's not available to us here yet.

@ocdtrekkie
Copy link
Owner Author

3ae4906 makes it a lot less likely someone will interrupt the updater, as the script is hidden when executing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant