Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a decision on Develops from property chain - accept or remove #2381

Closed
shawntanzk opened this issue Apr 5, 2022 · 7 comments
Closed
Assignees
Labels

Comments

@shawntanzk
Copy link
Collaborator

Develops from property chain removal (#1808) caused a lot of useful axioms to not be there.
While the removal was to solve some weird axioms @balhoff found, some of the axioms that it removed in uberon are still useful.
This leads to a bit of a conundrum on if we should remove it or not and needs discussion.
However, we cannot let this be a blocker anymore, so our plan is to insert the property chain as a component that is left out in base file.
This will allow the inferences to still be there, but leave it out from ontologies that use the base file (which hopefully more and more are)

This is a temp fix just to get the release out, but we still need to make a final decision on it:
should we generally accept it or generally reject it?

Tagging @cmungall & @dosumis too
Related to #2376

@shawntanzk
Copy link
Collaborator Author

develops_from o part_of -> develops_from - this is ok (though it should be restricted to anatomical entity on the left side too)
part_of o develops_from -> develops_from - is ok if left side is restricted to anatomical entity
Difficulty in expressing in owl?

For now:

  • Get rid of 2nd one, but add back the first one
  • Make a ticket on 2nd one to decide how to handle

@balhoff
Copy link
Member

balhoff commented Apr 25, 2022

It is easy to restrict to anatomical entity using rolification. Not sure if that works in Elk, but it does work in Whelk. I still think both chains are incorrect. In any case the chains should be added to RO and not Uberon.

@shawntanzk
Copy link
Collaborator Author

shawntanzk commented May 23, 2022

@balhoff - could you give some concerns with the above patterns so we can understand better please?
atm we will leave this alone, and only implement once we have a clear strategy on how to do it.
We have a bit of uncertainty on how to implement this and would be good if you had a better solution to this too.

@github-actions
Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@matentzn
Copy link
Contributor

As of today, they are both still in there.

@cmungall
Copy link
Member

We agreed a year ago to get rid of the 2nd, no controversy

Let's make a separate RO issue for adding the rolification constraint on the 1st. This is low priority as I will wager there are zero tbox existentials in OBO connecting organism to anything bigger. But the point is this should be a RO issue

@anitacaron
Copy link
Collaborator

Issue to remove part_of o develops_from -> develops_from in Uberon:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants