Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"refactor" the targetuserspacecreator actor (and other related) #486

Open
pirat89 opened this issue Apr 6, 2020 · 1 comment
Open

"refactor" the targetuserspacecreator actor (and other related) #486

pirat89 opened this issue Apr 6, 2020 · 1 comment

Comments

@pirat89
Copy link
Member

pirat89 commented Apr 6, 2020

See the #482 PR. I have created bunch of TODOs with instructions (later will be added here). The current shape is really bad, but regarding the lack of time, I rather chose to skip such refactoring now and do it after the next release. The proper refactoring should take into account instruction in TODOs and should include properly written unit-tests covering the functionality properly (currently, unit tests cover just small part of the whole functionality). Affected actors and libraries:

  • targetuserspacecreator
  • systemfacts
  • libraries/rhsm.py

Probably new check actor(s) could be created as well.
pirat89 added a commit to pirat89/leapp-repository that referenced this issue Apr 6, 2020
@pirat89
targetuserspacecreator: add checks for custom target repositories
41e7101 
Previously when any custom target repository was not available
inside the container (read, was not defined in a repo file), the
fact was ignored.

Currently, as user is able to proceed the upgrade without RHSM,
completely, we should focus more on these values as well, otherwise
it could happen we will not be able to create the target userspace
(which in such case could end with ugly pretty-long output of errors
immadiately after the fail of the bootstrap installation).

As well, if rhsm is skipped, check whether there are not duplicate
repository definitions inside the container. If so, inhibit the
upgrade (as it happens in case when RHSM is used).

Regarding the current state, the new issue has been created refactor
and modify significantly the actor and related labrares.

Issue: oamg#486
@pirat89 pirat89 mentioned this issue Apr 6, 2020
Merged
pirat89 added a commit to pirat89/leapp-repository that referenced this issue Apr 7, 2020
@pirat89
[RFE custom repos 9/9] targetuserspacecreator: add checks for custom …
aaef0e3 
…target repositories

Previously when any custom target repository was not available
inside the container (read, was not defined in a repo file), the
fact was ignored.

Currently, as user is able to proceed the upgrade without RHSM,
completely, we should focus more on these values as well, otherwise
it could happen we will not be able to create the target userspace
(which in such case could end with ugly pretty-long output of errors
immadiately after the fail of the bootstrap installation).

As well, if rhsm is skipped, check whether there are not duplicate
repository definitions inside the container. If so, inhibit the
upgrade (as it happens in case when RHSM is used).

Regarding the current state, the new issue has been created refactor
and modify significantly the actor and related labrares.

Issue: oamg#486
pirat89 added a commit to pirat89/leapp-repository that referenced this issue Apr 7, 2020
@pirat89
[RFE custom repos 9/9] targetuserspacecreator: add checks for custom …
0e9801d 
…target repositories

Previously when any custom target repository was not available
inside the container (read, was not defined in a repo file), the
fact was ignored.

Currently, as user is able to proceed the upgrade without RHSM,
completely, we should focus more on these values as well, otherwise
it could happen we will not be able to create the target userspace
(which in such case could end with ugly pretty-long output of errors
immadiately after the fail of the bootstrap installation).

As well, if rhsm is skipped, check whether there are not duplicate
repository definitions inside the container. If so, inhibit the
upgrade (as it happens in case when RHSM is used).

Regarding the current state, the new issue has been created refactor
and modify significantly the actor and related labrares.

Issue: oamg#486
pirat89 added a commit to pirat89/leapp-repository that referenced this issue Apr 7, 2020
@pirat89
[RFE custom repos 9/9] targetuserspacecreator: add checks for custom …
7677388 
…target repositories

Previously when any custom target repository was not available
inside the container (read, was not defined in a repo file), the
fact was ignored.

Currently, as user is able to proceed the upgrade without RHSM,
completely, we should focus more on these values as well, otherwise
it could happen we will not be able to create the target userspace
(which in such case could end with ugly pretty-long output of errors
immadiately after the fail of the bootstrap installation).

As well, if rhsm is skipped, check whether there are not duplicate
repository definitions inside the container. If so, inhibit the
upgrade (as it happens in case when RHSM is used).

Regarding the current state, the new issue has been created refactor
and modify significantly the actor and related labrares.

Issue: oamg#486
pirat89 added a commit to pirat89/leapp-repository that referenced this issue Apr 9, 2020
@pirat89
[RFE custom repos 9/9] targetuserspacecreator: add checks for custom …
5e0a693 
…target repositories

Previously when any custom target repository was not available
inside the container (read, was not defined in a repo file), the
fact was ignored.

Currently, as user is able to proceed the upgrade without RHSM,
completely, we should focus more on these values as well, otherwise
it could happen we will not be able to create the target userspace
(which in such case could end with ugly pretty-long output of errors
immadiately after the fail of the bootstrap installation).

As well, if rhsm is skipped, check whether there are not duplicate
repository definitions inside the container. If so, inhibit the
upgrade (as it happens in case when RHSM is used).

Regarding the current state, the new issue has been created refactor
and modify significantly the actor and related labrares.

Issue: oamg#486
pirat89 added a commit that referenced this issue Apr 16, 2020
@pirat89
[RFE custom repos 9/9] targetuserspacecreator: add checks for custom …
db0025a 
…target repositories

Previously when any custom target repository was not available
inside the container (read, was not defined in a repo file), the
fact was ignored.

Currently, as user is able to proceed the upgrade without RHSM,
completely, we should focus more on these values as well, otherwise
it could happen we will not be able to create the target userspace
(which in such case could end with ugly pretty-long output of errors
immadiately after the fail of the bootstrap installation).

As well, if rhsm is skipped, check whether there are not duplicate
repository definitions inside the container. If so, inhibit the
upgrade (as it happens in case when RHSM is used).

Regarding the current state, the new issue has been created refactor
and modify significantly the actor and related labrares.

Issue: #486
@pirat89 pirat89 pinned this issue Feb 27, 2021
@shaded-enmity shaded-enmity unpinned this issue Jan 25, 2022
@pirat89
Copy link
Member Author

pirat89 commented Jan 10, 2023

Relates to #973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pirat89