Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: health check #27

Open
vhyrro opened this issue Apr 7, 2024 · 5 comments
Open

[Feature]: health check #27

vhyrro opened this issue Apr 7, 2024 · 5 comments

Comments

@vhyrro
Copy link
Contributor

vhyrro commented Apr 7, 2024

rocks-config should have a :checkhealth integration that checks general configuration bits and bobs.

@tarcisioe
Copy link
Contributor

I'd like to tackle this, since we already have health.lua now. Are there any other checks you would suggest? One that comes to mind is checking if config.plugins_dir exists. Any others?

@mrcjkb
Copy link
Member

mrcjkb commented Apr 19, 2024

I would say a non-existent config.plugins_dir would be a warning, since it just means rocks-config.nvim is installed, but not doing anything.

Another check could be to validate the rocks.toml entry for this plugin against a schema, similar to how we do in rocks.nvim for vim.g.rocks_nvim

@tarcisioe
Copy link
Contributor

Oh nice. Is there any good way we could maybe share the code for doing checks between the plugins? Especially get_unrecognized_keys. Or maybe should I just go the simple way and duplicate that code here?

@mrcjkb
Copy link
Member

mrcjkb commented Apr 19, 2024

I like the idea.
We could extract a health-lib.nvim library with utilities.
If you want to take that on @tarcisioe, we could invite you to the neorocks org 😃

@tarcisioe
Copy link
Contributor

I'm somewhat new to developing Lua modules/libraries but I guess I can take a look on how other things are setup, so it's fine by me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants