Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we really need ActiveSupport gem in dependencies? #386

Closed
k0va1 opened this issue Apr 12, 2020 · 1 comment
Closed

Do we really need ActiveSupport gem in dependencies? #386

k0va1 opened this issue Apr 12, 2020 · 1 comment

Comments

@k0va1
Copy link

k0va1 commented Apr 12, 2020

I think it's not a good idea to put all activesupport stuff inside gem. Monkeypatching is shit
@dgb
Copy link
Contributor

dgb commented Jun 6, 2020

I'd love to remove ActiveSupport and make it an optional dependency (it's on our todo list here #351 (comment)). We are using it though, for both the monkeypatching stuff and instrumentation.

@dgb dgb closed this as completed Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgb @k0va1