Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split run_empire in Empire.py into several functions #5

Open
chriska85 opened this issue Jun 13, 2021 · 1 comment
Open

Split run_empire in Empire.py into several functions #5

chriska85 opened this issue Jun 13, 2021 · 1 comment

Comments

@chriska85
Copy link
Collaborator

Currently the full EMPIRE model setup and solution is handled in a single function run_empire in Empire.py. There are a number of ways to split it up into several more specialized functions which can be called from the main run_empire function. The advantage would firstly be improved code readability as it would be clearer which parts are sort of self-contained. Secondly, it would be possible to write unit tests for the individual functions which can be run in a continuous integration framework.

@martinhjel
Copy link
Collaborator

Agreed. The Blocks feature of Pyomo could be useful for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants