Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable names #6

Open
cjessett opened this issue Feb 28, 2018 · 1 comment
Open

Variable names #6

cjessett opened this issue Feb 28, 2018 · 1 comment

Comments

@cjessett
Copy link

cjessett commented Feb 28, 2018

(Important) Here these variable names do not represent the value of them. The names seem to imply they are booleans (either true or false) but are actually numbers. Instead of doing the comparison against the numbers in the if block, do the comparison in the variable declaration. This way they will be booleans and in the if block you can just check against true or false to make the same comparison only it will be much more readable.

@nikoyee
Copy link
Owner

nikoyee commented Mar 1, 2018

100% agree! Thanks for helping me write clearer codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants