Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems Reading Calendar #4

Open
amaliagj opened this issue Jun 7, 2021 · 1 comment
Open

Problems Reading Calendar #4

amaliagj opened this issue Jun 7, 2021 · 1 comment

Comments

@amaliagj
Copy link

amaliagj commented Jun 7, 2021

This isn't a huge issue and is more a documentation error I think:
"If there is no change in the external arrival rate through time, enter 0 in the start column and the arrival rate (0 if there are no external arrivals) in the Arrival Rate column." should be changed to "If there is no change in the external arrival rate through time, enter 0 in the start column, an arbitrary value in the end column, and the arrival rate (0 if there are no external arrivals) in the Arrival Rate column."

Currently when I run the simulation wizard in the app, I'm finding that I'm running into the "Missing ", j, " value entry in calendar" error if I fill out the calendars assuming the rates are always the same. I enter 0 for the start time and 5 for the external arrival rate, 0 for the capacity start time and 7 for the capacity, leaving the rest of the table blank. I see the missing value error for both the External Arrival Rate and Capacity calendars. Debugging it looks like the cal variable just remains empty (each value is chr "") and the values in the table aren't getting properly read in.

.....

Also adding this just for completeness - the current version of the app lead to a rowSums error for me the first time I ran it. The transition matrix was being read in as characters and the rowSums function wasn't happy, so I changed lines 3794 and 5036 to the following which resolved it: transition <- as.data.frame(lapply(f,as.numeric))

@ChrisBeeley
Copy link

I'd be interested to see a response about the error on line 3794 and 5036 in the issue above- if I'm going to run this code should I make the same alteration, have you looked at it in the team?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants