Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed trace for generic (not http) requests #233

Closed
VitorTrin opened this issue Jun 4, 2020 · 1 comment
Closed

Distributed trace for generic (not http) requests #233

VitorTrin opened this issue Jun 4, 2020 · 1 comment
Labels
feature request New feature or request

Comments

@VitorTrin
Copy link

VitorTrin commented Jun 4, 2020

Is your feature request related to a problem? Please describe.

Distributed trace works great for http requests, but there is no (clean) way to make it work when the request isn't related to http.

Describe the solution you'd like

A function that creates a serialized context, most likely DistributedTrace.distributed_trace_headers(:generic), and a function that takes a serialized context and adds to the current transaction, akin to DistributedTrace.track_transaction(context, transport_type: transport_type) but that accepts the serialized context.

Describe alternatives you've considered

The current workaround is to call DistributedTrace.distributed_trace_headers(:http), make them serializeble on our own, add to the request, and the other side takes the serialized headers, builds a conn, adds the headers and calls W3CTraceContext.extract() to get a built context.

@binaryseed binaryseed added the feature request New feature or request label Jun 4, 2020
@binaryseed
Copy link
Collaborator

Duplicate: #265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants