Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocketのメッセージの型 #12

Open
negi-grass opened this issue Jan 25, 2023 · 1 comment
Open

WebSocketのメッセージの型 #12

negi-grass opened this issue Jan 25, 2023 · 1 comment
Labels
before 1.0.0 This issue should be solved before v1.0.0 breaking This issue or pull request involves a breaking change help wanted Extra attention is needed

Comments

@negi-grass
Copy link
Owner

現状では、WebSocketのメッセージの型はWebSocketHandlerのそれぞれの実装が決めているが、RequestHandlerのように、ユーザーが指定した型に変換できるようにするべきか。

検討するべき点

  • bitFlyerのメッセージは本文と関係のない部分も多いが、そのまま渡すのか。
  • 認証や購読成功のメッセージはどう扱うか。

現状はbitFlyerだけserde_json::Valueでないので、仕様に統一感がない。

@negi-grass negi-grass added help wanted Extra attention is needed before 1.0.0 This issue should be solved before v1.0.0 breaking This issue or pull request involves a breaking change labels Jan 25, 2023
@negi-grass
Copy link
Owner Author

#7 のレスポンスのメッセージをどうするのか、という問題もある。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before 1.0.0 This issue should be solved before v1.0.0 breaking This issue or pull request involves a breaking change help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant