Skip to content
This repository has been archived by the owner on Jan 18, 2023. It is now read-only.

RFC: use makefile switch #9

Open
dahankzter opened this issue Sep 2, 2013 · 6 comments
Open

RFC: use makefile switch #9

dahankzter opened this issue Sep 2, 2013 · 6 comments
Assignees

Comments

@dahankzter
Copy link

I am not sure if this has been discussed somewhere but if so I apologize.

My suggestion is just a switch "-make" or "-use-make" to tell looper to use a makefile if one is available possibly recursively for each directory.

If you agree that it is sound or have another suggestion I am willing to give it a shot at implementing it.

@nathany
Copy link
Owner

nathany commented Sep 2, 2013

@dahankzter Sounds like a good suggestion. I've added it to the roadmap.

I don't currently have a good way to pass switches around, and I'm still trying to figure out better ways to generalize the system (build/test/assets) while also providing interactions for things like memory profiling and benchmarks.

Lets leave this on the back burner until I do some restructuring. Thanks.

@nathany
Copy link
Owner

nathany commented Sep 22, 2013

@dahankzter Do you have any particular requirements for what this flag would do? Just run make test?

@dahankzter
Copy link
Author

That would work for my case but if you have something more generic in mind like -exec "my_build.sh" or similar that works fine too.

Both options would probably be nice. -make=test and -exec=script.sh.

If you want to hide the make arguments then "make test" is probably a good target.

@nathany
Copy link
Owner

nathany commented Dec 13, 2014

Recently support was added to detect Godep and automatically use the right command there. It's an interesting approach that is nice when it works, I'm not sure how far I can take it.

But detecting "Makefile" and running "make test" instead is a possibility.

@nathany nathany self-assigned this Dec 13, 2014
@dahankzter
Copy link
Author

Perhaps just allowing arbitrary exec? It would make for a simple way to run whatever on change and not limit it to building Go projects?

The use case in mind right now is that on a mixed Mac and Linux team the linux users has a really easy way to use inotify-tools to do this but on Mac it seems to be a hassle. Having a tool like looper would be really neat and would make it easy to use on different envs. A general purpose fallback "exec" method would allow us to use looper for most everything and once a particular use case falls out as very common we could talk to you and perhaps extend its API with a new switch.

These things could (off the top of my head) be perhaps make it docker aware or something else completely unknown. Not suggesting it, it was just an example.

@nathany
Copy link
Owner

nathany commented Dec 18, 2014

Some combination of arbitrary exec and built in features could make for a good combo. I'll give it some more thought.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants