Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing override keyword #112

Open
wassgha opened this issue Jul 31, 2022 · 0 comments
Open

Fix missing override keyword #112

wassgha opened this issue Jul 31, 2022 · 0 comments

Comments

@wassgha
Copy link

wassgha commented Jul 31, 2022

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-google-nearby-messages@1.0.22 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-google-nearby-messages/ios/GoogleNearbyMessages.swift b/node_modules/react-native-google-nearby-messages/ios/GoogleNearbyMessages.swift
index 8035174..06dbe6f 100644
--- a/node_modules/react-native-google-nearby-messages/ios/GoogleNearbyMessages.swift
+++ b/node_modules/react-native-google-nearby-messages/ios/GoogleNearbyMessages.swift
@@ -231,7 +231,7 @@ class NearbyMessages: RCTEventEmitter {
 
 	// Called when the UIView gets destroyed (e.g. App reload)
 	@objc
-	func invalidate() {
+    override func invalidate() {
 		print("GNM_BLE: invalidate")
 		disconnect()
 	}
diff --git a/node_modules/react-native-google-nearby-messages/ios/GoogleNearbyMessagesBridge.h b/node_modules/react-native-google-nearby-messages/ios/GoogleNearbyMessagesBridge.h
index ce3c532..b0ca220 100644
--- a/node_modules/react-native-google-nearby-messages/ios/GoogleNearbyMessagesBridge.h
+++ b/node_modules/react-native-google-nearby-messages/ios/GoogleNearbyMessagesBridge.h
@@ -3,8 +3,8 @@
 //
 
 #import <Foundation/Foundation.h>
-#import "RCTBridgeModule.h"
-#import "RCTEventEmitter.h"
+#import <React/RCTBridgeModule.h>
+#import <React/RCTEventEmitter.h>
 #import "GNSMessages.h"
 
 @interface GoogleNearbyMessagesBridge: NSObject
diff --git a/node_modules/react-native-google-nearby-messages/ios/GoogleNearbyMessagesBridge.m b/node_modules/react-native-google-nearby-messages/ios/GoogleNearbyMessagesBridge.m
index 17c67f8..a56f633 100644
--- a/node_modules/react-native-google-nearby-messages/ios/GoogleNearbyMessagesBridge.m
+++ b/node_modules/react-native-google-nearby-messages/ios/GoogleNearbyMessagesBridge.m
@@ -7,8 +7,8 @@
 //
 
 #import "GoogleNearbyMessagesBridge.h"
-#import "RCTBridgeModule.h"
-#import "RCTEventEmitter.h"
+#import <React/RCTBridgeModule.h>
+#import <React/RCTEventEmitter.h>
 
 @interface RCT_EXTERN_REMAP_MODULE(GoogleNearbyMessages, NearbyMessages, NSObject)
 

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant