Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close banks to recover rent #256

Open
jgur-psyops opened this issue Oct 22, 2024 · 2 comments
Open

Close banks to recover rent #256

jgur-psyops opened this issue Oct 22, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jgur-psyops
Copy link
Contributor

Provided a bank has no outstanding deposits, loans, or collected fees, add an ix to close a bank to recover the account rent.

@jgur-psyops jgur-psyops added the enhancement New feature or request label Oct 22, 2024
@jgur-psyops jgur-psyops added the good first issue Good for newcomers label Dec 29, 2024
@0xathletic
Copy link

@jgur-psyops would you share more details on this issue?
any materials or code files to kick off ...

@jgur-psyops
Copy link
Contributor Author

@jgur-psyops would you share more details on this issue? any materials or code files to kick off ...

some Integrators have asked for a command similar to account closure https://github.com/mrgnlabs/marginfi-v2/blob/main/programs/marginfi/src/instructions/marginfi_account/close.rs

for defunct banks that no longer have any assets or banks created by accident. We want to avoid allowing banks to be closed if they have any participating users in any way, for example a bank might have zero assets but still owe some emissions, in which case it should stay live, so there are some edge cases here. A MWE can support just banks created in the future.

This is relatively low priority because the associated rent is not that much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants