-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesnt work ... dud addon #16
Comments
Thank you for your feedback. Just to make sure I understand, was the phrase part of the URL of the tab you are closing? Or was it part of the content of the tab? The addon does not support the latter. |
Content. |
I see. This is not yet supported. Will try to add support for that in the future. |
Ok thanks, There is never any purpose for me to close down tabs containing a url so I assumed it was for body text. , but there is a huge need for closing down tabs containing a string of text. |
Is there though? It never occurred to me to close any tabs based on this method. Or any vim buffers. Or, the list goes on. |
Of course there is. One example is is for auction sites which you batch open in tabs for results as items found for a query. It always returns tabs with no results and always state fix text on the return. |
@circuitikzuser I absolutely came around to your idea even when I read it again the other day! We can do it. Back then I forked this project and made it my own: At the time I wanted to be able to type multiple strings into the input at once, to match many tabs. I think with your wishes, it'd be best to have this be a preference, such as a toggle in the popup, or a For this, I'd likely just fork/contribute the changes to this repo, and not mine. Mine is too personalized now for anyone lol @mos3abof can you open this back up? I will contribute the change, once we decide the best way this feature can be utilized |
This is an interesting discussion! Did not expect the conversation to be live after all these years :) |
This will be great, but wont forking create a lot of problems maintaining it ? Just a note: In my case, the text that should trigger the tab close, is usually in the BODY of the page. Just in case we misunderstand each other. I dont know if that would be more difficult, but sure would be nice ? |
As an example. Pages to be closed will e.g. contain the following text in the body. |
Just to mention my experience.
I needed an addon in firefox that will close a tab containig a certain phrase.
Installed power-close, entered the phrase in the text box from the menu icon created and nothing happens. It does squat and the Tab still remains . I tried putting the phrase in quotation marks and that didnt work either.
The text was updated successfully, but these errors were encountered: