Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Missed icons + unable to save project #24

Open
DreadDendy opened this issue Nov 20, 2024 · 3 comments
Open

[windows] Missed icons + unable to save project #24

DreadDendy opened this issue Nov 20, 2024 · 3 comments
Assignees
Labels

Comments

@DreadDendy
Copy link

Hi, I have tested Tsunami again and found some new missed icons.
missed_icon

Another bug - it is impossible to save the project.
The application is crashing when I click on "Save As" or "Save".

@momentarylapse
Copy link
Owner

I can confirm the crash when saving. It only happens on windows, and only with the "packaged" release build. I strongly suspect it is the gtk/file dialog integration, probably a (silently) missing DLL. I'll look into it, but not sure if I'll find time before the weekend. I'll take the file down again. That is a pretty severe problem!

The missing icon on the right, I also saw directly after uploading. So far, it seems to be the only one missing. I'll add it next time.

The one on the left is more complex. It is a unicode symbol (violin clef) rendered using system fonts. The default fonts on windows don't cover musical symbols. Two options:

  • I could recommend (or provide) a font to install - needs some research, since gtk does not tell me which font it is actually using on linux (where it looks good). Also overkill, since only a few symbols are used/missing
  • switch to fixed icons/vector graphics
    I strongly favor the vector graphics and I had planned to create those for many years, but was too lazy before. Now there is finally an incentive.

Again, thanks a lot for your experiments and report!

@DreadDendy
Copy link
Author

I strongly favor the vector graphics and I had planned to create those for many years, but was too lazy before. Now there is finally an incentive.

I agree, this will be a more correct approach.

Also I tried to find anything about weird black border (bug 2 from #18).
And it seems like this is indeed a GTK thing, which happens for some people for many years. Even on Linux,
numixproject/numix-gtk-theme#206
https://unix.stackexchange.com/questions/419969/some-gtk-apps-have-black-border-in-plasma
https://gitlab.gnome.org/GNOME/gtk/-/issues/6192
https://www.reddit.com/r/kde/comments/17j4i3s/black_border_around_gtk_app/?sort=old
https://gitlab.gnome.org/GNOME/gtk/-/issues/6890

@momentarylapse
Copy link
Owner

thanks for the research. This suggests, that the problem might not be (perfectly) solvable for us, but we might be able to add a workaround, e.g. a setting for deactivating the transparent borders. I'll try that out.

Also good news for the crash when saving. Found a solution in this discussion. Some "schema" files needed to be copied. I tried it and the crashes stoped.

I should be able to provide another upload soon-ish.

@momentarylapse momentarylapse self-assigned this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants