Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noise divisor code should not be incremented #35

Open
42plamusse opened this issue Apr 4, 2022 · 0 comments
Open

Noise divisor code should not be incremented #35

42plamusse opened this issue Apr 4, 2022 · 0 comments

Comments

@42plamusse
Copy link

gameboy/src/apu.rs

Line 998 in 87865c1

n => (u32::from(n) + 1) * 16,

n should not be incremented by 1. Otherwise, by example, if n = 1 you will get a divisor value of 32 instead of the 16 expected.

You can also use this operation instead:

n => u32::from(n) << 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@42plamusse