Atom <logo> is cropped into a squared icon even if it should be 2:1 landscape according to specs

[AlphaJack]

Expected behavior

Feeder app shows my squared "icon.png" as feed icon

Actual behavior

Feeder app crops my landscape "logo.png" as feed icon

Steps to reproduce the behavior

1. Have a feed with a squared icon and 2:1 logo, as per specs: https://validator.w3.org/feed/docs/atom.html#optionalFeedElements
2. Use the Feeder app to subscribe to the feed.

---

I'm posting here because the Feeder author mentioned it's a gofeed behavior: spacecowboy/Feeder#270 (reply in thread)

[spacecowboy]

To rephrase: the user wants icon to be prioritized before logo for atom feeds.

There is no way for a client to pick between them since gofeed picks one.

Personally I do not consider this a problem.

[mmcdole]

This is a case where you might want to use a custom translator. The universal feed type needs to choose one field when mapping from format-specific fields (like Atom's icon and logo), but you can create your own translator to change this behavior.

The README shows how to use custom translators. You can implement the gofeed.Translator interface to customize how Atom feeds are translated into the universal feed type. This would let you prioritize icon over logo or even preserve both fields.

Here's a basic example:

type MyTranslator struct {
    *DefaultAtomTranslator
}

func (t *MyTranslator) Translate(feed interface{}) (*gofeed.Feed, error) {
    atomFeed := feed.(*atom.Feed)
    f, err := t.DefaultAtomTranslator.Translate(feed)
    if err != nil {
        return nil, err
    }
    
    // Prioritize icon over logo
    if atomFeed.Icon != "" {
        f.Image = &gofeed.Image{URL: atomFeed.Icon}
    } else if atomFeed.Logo != "" {
        f.Image = &gofeed.Image{URL: atomFeed.Logo}
    }
    
    return f, nil
}```

[spacecowboy]

Thanks for the example