You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
Would it be possible to add support for Firefox forks (IceWeasel, IceCat, ...)? By this I mean that the addon already works on them, but the notification displays a Firefox icon rather than the icon of the browser that's actually being used. Or is this already supposed to happen?
The text was updated successfully, but these errors were encountered:
There is a workaround for this already. In the add-on options called 'Notification icon' which should be set to 'default' by default. The current code has checks for Iceweasel, Thunderbird, Firefox, and SeaMonkey with those exact spellings. If the system.name doesn't match any of those values, it defaults to firefox.
There's also a distinct possibility that a particular fork doesn't change the system.name, in which case we'll need to find another way to determine which icon to use.
That's right. For instance, if you run IceWeasel, Gnotifier will try to use "iceweasel" icon form your system (typically icon file is somewhere in /usr/share/icons/). If you want another icon, you can define different name on the add-on's settings page.
The thing I can think about is to pack icon files (for Iceweasel, Icecat ect.) directly in to add-on package.
Pros -> Icons will be displayed correctly regardless if file is present in /usr/share/icons/ or not.
Cons -> If system theme provides modified icon, it will not be used for notification.
@kabili207 I've checked system.name for IceCat. It provides "Icecat" string :-)
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Would it be possible to add support for Firefox forks (IceWeasel, IceCat, ...)? By this I mean that the addon already works on them, but the notification displays a Firefox icon rather than the icon of the browser that's actually being used. Or is this already supposed to happen?
The text was updated successfully, but these errors were encountered: