Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamline process_parameters #33

Open
mikarubi opened this issue Sep 5, 2024 · 2 comments
Open

streamline process_parameters #33

mikarubi opened this issue Sep 5, 2024 · 2 comments

Comments

@mikarubi
Copy link
Owner

mikarubi commented Sep 5, 2024

Remove redundant validation of parameters from process_parameters (after #31 is merged) because this validation now occurs in parameter_models

@luiztauffer
Copy link
Collaborator

as of now, if a parameters file (json) already exists, the default behavior is to load from it.
should we have an optional flag, e.g. overwrite: bool = False, that allows the user to overwrite the local file with a new processed parameters dict?

@mikarubi
Copy link
Owner Author

mikarubi commented Sep 6, 2024

No, the current setup is good. The idea is that once a parameter file is created, it should not be overwritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants