Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Terminal Chat] Shift+Enter should add a newline in the textbox #17940

Closed
carlos-zamora opened this issue Sep 20, 2024 · 1 comment · Fixed by #17993
Closed

[Terminal Chat] Shift+Enter should add a newline in the textbox #17940

carlos-zamora opened this issue Sep 20, 2024 · 1 comment · Fixed by #17993
Assignees
@PankajBhojwani
Labels
Area-Chat All things LLM or "AI" In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.23

Comments

@carlos-zamora
Copy link
Member

I pressed "Shift+Enter" expecting a newline and accidentally submitted my query.

With the text box being so large, it feels like "Shift+Enter" should be accepted to add newlines.

I think this is an easy fix. We might just have to use this property: https://learn.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.textbox.acceptsreturn?view=winrt-26100#windows-ui-xaml-controls-textbox-acceptsreturn
@carlos-zamora carlos-zamora added the Area-Chat All things LLM or "AI" label Sep 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 20, 2024
@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 2, 2024
@carlos-zamora carlos-zamora modified the milestones: Backlog, Terminal v1.23 Oct 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Oct 2, 2024
@PankajBhojwani PankajBhojwani mentioned this issue Oct 3, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Oct 3, 2024
DHowett pushed a commit that referenced this issue Oct 4, 2024
@PankajBhojwani
Allow shift+enter in Terminal Chat's text box (#17993)
c989f86 
You can now press shift+enter in the Terminal Chat query box to enter
newlines

Closes #17940
@PankajBhojwani
Copy link
Contributor

Fixed in #17993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Chat All things LLM or "AI" In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.23
Development

Successfully merging a pull request may close this issue.

Allow shift+enter in Terminal Chat's text box microsoft/terminal
2 participants
@carlos-zamora @PankajBhojwani