Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GenerateSchemaJsonHeader.ps1 to fix linker issues when including SchemaJson.h in multiple translation units #26

Open
chriche-ms opened this issue Jan 21, 2019 · 0 comments

Comments

@chriche-ms
Copy link
Member

The generated header SchemaJson.h has some issues:

  1. Class SchemaJson should be a namespace
  2. Schema strings (e.g. accessor_schema_json) don't follow the correct naming convention, and should either be defined in a separate .cpp or made constexpr const char[] to avoid linker issues.
  3. Bracing style is not consistent with the rest of the codebase
  4. GLTF_SCHEMA_MAP should be defined in a separate .cpp file.
  5. Schema URIs shouldn't be hardcoded literals, instead move the relevant variables from Schema.h into the generated header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants