-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Date/time fields in grids are sorted alphabetically #81
Comments
Date/time colums used to be formatted as "yyyy-MM-dd H:mm", which would result in the correct order when sorting. However, according to #24 , some users receive the date/time information in a format (e.g. " 31/01/2019 01:10") which could not be deserialized into a The date/time format is controlled by the language preference of the user in LCS. 2LCS uses Json.NET for parsing the JSON data returned from LCS. By default, Json.NET uses the invariant culture (which corresponds with the en-US culture, which is the "English (United States)" language preference in LCS). One was to solve this would be to get the language preference of the user from LCS. Another way would be to provide a parameter in 2LCS were the user could set the language preference. |
Only works with LCS language preference set to "English (United States)". See also microsoft#81
@FH-Inway maybe best way for now is to get system user settings really. In a way should be the same as the settings in LCS. |
@fraga Thanks for the suggestion. Yes, I had a similar thought. I think we still would need a fallback, since probably many users have a non-us system setting, but never bothered with changing the language preference of LCS. |
When clicking on a grid column header, the grid data gets sorted (ascending on first click, descending on second). The sorting always seems to be alphabetically and not take the data type into account. This works for most columns, but date/time columns are an issue.
For example, here is the "Deployed On" column in the "Cloud-hosted instances" grid after the first click (should be sorted ascending):
The text was updated successfully, but these errors were encountered: