You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I also noticed that in the default libGDX shader spherical harmonics are implemented but there's nothing that sets the sphericalHarmonicsFlag in the Java side..
@mgsx-dev I did a POC implementation of SH in your library.. Doesn't looks like so bad, I'm not sure if the shader and calculations are right, basically I copied from official google ar example (https://github.com/google-ar/arcore-android-sdk/tree/master/samples/hello_ar_java) which include a PBR shader. I'd like to know what do you think, if and how could be improved, etc. fgnm/ARPlayground@e9c75b2 a part from extended Java classes the only glsl I've modified is the pbr.fs.glsl adding spherical harmonics.
Again, this could be another minor feature, however could be nice to have :)
A brief explain of Spherical Harmonics can be found in the ARCore documentation, with also some examples: https://developers.google.com/ar/develop/lighting-estimation#ambient_spherical_harmonics
I also noticed that in the default libGDX shader spherical harmonics are implemented but there's nothing that sets the
sphericalHarmonicsFlag
in the Java side..gdx-gltf/gltf/src/net/mgsx/gltf/shaders/default.vs.glsl
Lines 279 to 289 in c8047c2
Weird, btw this could be an improvement to this library, a lot of PBR rendering implements this feature.
Thanks!
The text was updated successfully, but these errors were encountered: