Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only ad zones should be forced to the last column #9

Open
pilgreen opened this issue Aug 18, 2023 · 1 comment
Open

Only ad zones should be forced to the last column #9

pilgreen opened this issue Aug 18, 2023 · 1 comment

Comments

@pilgreen
Copy link
Contributor

The zone class is appended to all zones injected. I don't really think we should change that, but SDS is setting all zones to the last column by default. Should we narrow this to .zone[data-type="ad"] instead?
@gabrielakhanna
Copy link
Contributor

I think that's a good move!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pilgreen @gabrielakhanna