Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Inaccurate fame tracker #37

Open
Jay-Day opened this issue May 26, 2020 · 3 comments
Open

[BUG] Inaccurate fame tracker #37

Jay-Day opened this issue May 26, 2020 · 3 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@Jay-Day
Copy link

Jay-Day commented May 26, 2020

Describe the bug
The app doesn't take into account the premium buff for players when gaining fame.

To Reproduce
Steps to reproduce the behavior:

  1. have the app open and ready
  2. be on an account with premium
  3. kill 1 mob and check combat log for total fame earned for that mob
  4. the amount of fame in the meter is off by the bonus of premium.

Expected behavior
Honestly not sure of the expected behavior, I'm not even sure if this is always how the app has worked I just assumed before that it took into account premium status for the player.

Screenshots
can add later if needed

Desktop (please complete the following information):

  • OS: windows
@GaLzZy
Copy link

GaLzZy commented Jun 1, 2020

All he would have to do is put a checkbox, and if the checkbox is checked, premium is active and fame is = fame + (.5 * fame) or something i think

@Java-Superman
Copy link

I think it is best to report the fame consistently rather than the added bonuses (premium, avalonian dungeon, other fame buffs).

@mazurwiktor mazurwiktor added enhancement New feature or request help wanted Extra attention is needed labels Jun 4, 2020
@GuillaumeFavelier
Copy link

I like the checkbox idea (at least you have the option). Anybody down for a PR?

@mazurwiktor mazurwiktor added the bug Something isn't working label Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants