Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL coding style - Indentation #1

Open
purnendudash opened this issue Oct 23, 2024 · 2 comments
Open

SQL coding style - Indentation #1

purnendudash opened this issue Oct 23, 2024 · 2 comments

Comments

@purnendudash
Copy link

Sql statement should follow this indentation style - https://moodledev.io/general/development/policies/codingstyle/sql#indentation

$sql = 'SELECT sequence FROM {course_sections} WHERE course = :course AND sequence > "" ORDER BY section';

@marcusgreen
Copy link
Owner

marcusgreen commented Oct 23, 2024

Can I confirm you mean it should have a line break after the keywords like this


$sql = 'SELECT sequence FROM {course_sections} 
        WHERE course = :course
        AND sequence > "" 
        ORDER BY section';

Always delighted to get feedback, I am very keen on complying with the coding standards.

marcusgreen added a commit that referenced this issue Oct 24, 2024
@marcusgreen
Copy link
Owner

I have formatted the sql as you can see from that commit above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants