Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange behaviour with mailto links and twitter plugin #4

Open
pawelgorzelany opened this issue Dec 22, 2010 · 2 comments
Open

Strange behaviour with mailto links and twitter plugin #4

pawelgorzelany opened this issue Dec 22, 2010 · 2 comments

Comments

@pawelgorzelany
Copy link

I found some more bugs. One in the main script and the other in the twitter plugin.
The first one is that when you got two email adresses, without the mailto: prefix, inline with the text and separated by it like this:
some text some@email.com text another@email.com text
after linkifing it concatenates both email addresses and the text between in one link like this:
some text ... text
that doesn't apply when i put mailto: in front of the email address.

One in the plugin is with hashtags. It makes links to twitter search api's out of things like
# hashtag
even though the text is separated by a space from # which actually is not a twitter hashtag then.

The other one is that, when you got more than one twitter username or hashtags in the text, only the first ones got replaced by links. So if you have
text @user1 text @user2 text #hashtag1 @user3 #hashtag2
linkfing will return links only for @user1 and #hashtag1. Others will stay as they are.

@maranomynet
Copy link
Owner

Thanks. It seems I need to revisit my simple, quickly cobbled together RegExps. :-)

@maranomynet
Copy link
Owner

FYI, I've committed a fix for the last bug that you pointed out - and a bunch of failing unit tests that highlight the rest (and some more bugs)

I'll work on elminiating those when I get the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants