-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Places where API key swapping is not happening #312
Comments
Android
|
Mobility There are several pages where none gets replaced. However, it does update on the tutorial, so it's less likely a build issue.
https://dev.mapzen.com/documentation/mobility/optimized/api-reference/#error-checking
https://dev.mapzen.com/documentation/mobility/matrix/api-reference/#inputs-of-the-matrix-service (note, I have fixed the mapzen-x reference on this page in a later commit) |
I described my hunch in @rmglennon in Slack, here it is: It seems that what all these code blocks have in common is that they were parsed with the Markdown parser's Codehilite module, which injects inline HTML elements around the text. This is a contrived example for illustration purposes only, but the output looks something like this: your<span>-</span>mapzen-api-key To the human eye, the elements are invisible and read the same as the string After looking around to see if there are good examples for making RegExps that ignore HTML, it seems that there's really no good way to do it. Instead we should rely on something else (like Mark.js, instead of writing our own code) that is capable of parsing HTML and doing word searches across HTML boundaries. Since we are likely to need to parse HTML anyway to do interactive elements (e.g. for signing in, switching keys) this seems like it is time to adjust our solution in that direction. |
Cartography
https://github.com/tangrams/cartography-docs/pull/30/files#diff-392e93c0f22d45cc0a06008607fe6e3cL25
The text was updated successfully, but these errors were encountered: