Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manifold-ext] Implementing Map requires implementing ICallHandler#call #636

Open
ByThePowerOfScience opened this issue Nov 6, 2024 · 1 comment

Comments

@ByThePowerOfScience
Copy link

ByThePowerOfScience commented Nov 6, 2024

Describe the bug
When writing a class that implements java.util.Map while using manifold-ext, IDEA's linter requires that I override ICallHandler#call since it does not have a default implementation in the interface.

To Reproduce
Steps to reproduce the behavior:

  1. Make a class that implements Map
  2. The IDE will display a red line under the class declaration saying that you need to implement call.

Expected behavior
As ICallHandler doesn't actually exist on the Map type, it shouldn't be required to be implemented on a custom map.

Desktop (please complete the following information):

  • OS Type & Version: OSX 12.7.6
  • Java/JDK version: 17
  • IDE version (IntelliJ IDEA or Android Studio): IDEA 2024.1.7
  • Manifold version: manifold-delegation:2024.1.38
  • Manifold IntelliJ plugin version: 2024.1.13
@rsmckinney
Copy link
Member

Thanks for reporting this. What I see in IntelliJ is this is only an issue when you generate the implementation via Implement methods quick fix, it automatically selects the call() method for implementation, if you unselect it, all is well. I am looking into why IJ is doing this since, internally, call() is modeled as a default interface method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants