Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style-Framework examples don't work on 0.19.1 #8

Open
nova-nowiz opened this issue Dec 29, 2020 · 2 comments
Open

Style-Framework examples don't work on 0.19.1 #8

nova-nowiz opened this issue Dec 29, 2020 · 2 comments

Comments

@nova-nowiz
Copy link

I have modified the FrameworkCustomized example for it to work on 0.19.1 if you want me to make a pull request @lucamug.

@lucamug
Copy link
Owner

lucamug commented Jan 9, 2021

Yes, thanks.

I will refresh the readme of this library too

@nova-nowiz
Copy link
Author

As I was reviewing my modifications today, I realized that my pull request isn't acceptable.
Basically, I had to change the module used in the framework in Configuration.elm from MyStyle to FrameworkConfiguration as MyStyle (FrameworkConfiguration being the file that I use to override the config):
image
Basically, it is a requirement to make a copy of the framework to do modifications on the configuration.
My example fix for 0.19.1 is not local to the example. I should have said so in my previous comment.
Another fix is to remove the MyStyle.elm file in the framework.

However, this customization problem #9 is not the only one as Flags don't work too. I had to put the initModel and initCmd functions in FrameworkCustomized.elm, modify them, and also modify the init function to make the example work.

I think a rewrite as a whole for might be necessary to make it work with the latest version of elm.
Modifying the readme to state that this library can only be used in 0.19.0 and not in 0.19.1 is a good idea.
Do you want me to still make a pull request so that you can view my changed @lucamug?

On another note, I saw on your github that you were working at rakuten and making the r10 package. do you think this is a good replacement for style-framework? And in this case, it might be a good idea to redirect users using 0.19.1 to this new library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants