Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GSL dependency #182

Open
Tracked by #181
hombit opened this issue Oct 15, 2024 · 0 comments
Open
Tracked by #181

Remove GSL dependency #182

hombit opened this issue Oct 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@hombit
Copy link
Member

hombit commented Oct 15, 2024

GSL provides a fast gradient slope method we use for *Fit features, but also causes a lot of problems:

  • It is GPL-licensed (as well as the corresponding Rust crate), so it is causing this project to be GPL-licensed (see Switch license to MIT #181)
  • Wrapper crate doesn't distribute sources and build routines, so it is the only dependency user must have installed to build this package with the full functionality
  • It is significantly faster than Ceres, but it is also has significantly worse precision, see https://ui.adsabs.harvard.edu/abs/2024ApJ...974..169D/abstract and example code in this repo.
@hombit hombit mentioned this issue Oct 15, 2024
3 tasks
@hombit hombit changed the title Remove GPL dependency Remove GSL dependency Oct 15, 2024
@hombit hombit added the enhancement New feature or request label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant